New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substitution breaks for commands substitution #120

Closed
pytoxbot opened this Issue Sep 17, 2016 · 5 comments

Comments

Projects
None yet
1 participant
@pytoxbot

pytoxbot commented Sep 17, 2016

Since there doesn’t seem to be a way to describe several environments at once like [testenv:py32,py33] or just [testenv:py3] (please correct me if I’m wrong :)) I would like to substitute commands but when I do this:

[testenv:py32]
commands = py.test --cov structlog --cov-config=.coveragerc.py3

[testenv:py33]
commands = {[testenv:py32]commands}

I’ll get

ERROR: InvocationError: could not find executable 'py.test --cov structlog --cov-config=.coveragerc.py3'

If I copy and paste the command line, it works fine.

My guess is that it tries to treat the whole command line as the executable instead of just py.test and splitting the rest as arguments?

@pytoxbot

This comment has been minimized.

pytoxbot commented Sep 17, 2016

Original comment by @hpk42

Merged in wmyll6/tox/fix-issue-120-commands-subs (pull request #143)

fix issue #120: section subs in commands doesn't work

→ <>

@pytoxbot

This comment has been minimized.

pytoxbot commented Sep 17, 2016

Original comment by @hpk42

fix issue #120: section subs in commands doesn't work

Problem

Section substitution for commands doesn't work correctly.

Acceptance

When section substitution is specified as a single form of commands declaration
it is replaced with parsed list of commands.

When section substation happens as part of the other command line declaration - preserve original behaviour.

Changes

  • fixes for the issue
  • some PEP8 violations are fixed
  • tests for the substation in commands are grouped

→ <>

@pytoxbot

This comment has been minimized.

pytoxbot commented Sep 17, 2016

Original comment by @hpk42

Merged in wmyll6/tox/fix-issue-120-commands-subs (pull request #143)

fix issue #120: section subs in commands doesn't work

→ <>

@pytoxbot

This comment has been minimized.

pytoxbot commented Sep 17, 2016

Original comment by @jenisys

Issue #133 was marked as a duplicate of this issue.

@pytoxbot

This comment has been minimized.

pytoxbot commented Sep 17, 2016

Original comment by @hpk42

Substitution indeed does not work with commands, kind of a known limitation which should be lifted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment