Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore command exit codes #124

Closed
pytoxbot opened this issue Sep 17, 2016 · 5 comments
Closed

ignore command exit codes #124

pytoxbot opened this issue Sep 17, 2016 · 5 comments

Comments

@pytoxbot
Copy link

@pytoxbot pytoxbot commented Sep 17, 2016

Sometimes it's desirable to ignore the exit code of a command, in the commands option of a testenv section.

I would like to suggest adding a "-" prefix like in Makefiles. When a command has such a prefix, tox should ignore the exit code of that command.

example:

#!ini

[testenv:py27]
commands = coverage erase
           {envbindir}/python setup.py develop
           coverage run -p setup.py test
           coverage combine
           - coverage html
           {envbindir}/flake8 loads

Here, the 5th command may return false, but this can be ignore

@pytoxbot
Copy link
Author

@pytoxbot pytoxbot commented Sep 17, 2016

Original comment by @hpk42

Merged in mhirota/tox (pull request #133)

Fix issue #124

→ <<cset 4298877e4216>>

@pytoxbot
Copy link
Author

@pytoxbot pytoxbot commented Sep 17, 2016

Original comment by @hpk42

Fix issue #124

→ <>

@pytoxbot
Copy link
Author

@pytoxbot pytoxbot commented Sep 17, 2016

Original comment by @hpk42

Merged in mhirota/tox (pull request #133)

Fix issue #124

→ <<cset 4298877e4216>>

@pytoxbot
Copy link
Author

@pytoxbot pytoxbot commented Sep 17, 2016

@pytoxbot
Copy link
Author

@pytoxbot pytoxbot commented Sep 17, 2016

Original comment by @hpk42

i think that's a good idea, happy about a PR.

@pytoxbot pytoxbot closed this Sep 17, 2016
@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant