Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do about python3.10 #1374

Closed
asottile opened this issue Jul 20, 2019 · 8 comments · Fixed by #1377
Closed

What to do about python3.10 #1374

asottile opened this issue Jul 20, 2019 · 8 comments · Fixed by #1377

Comments

@asottile
Copy link
Member

@asottile asottile commented Jul 20, 2019

Should we make tox -e py310 work? Should we introduce a new thing that's tox -e py2.7 such that it's unambiguous?

@obestwalter
Copy link
Member

@obestwalter obestwalter commented Jul 20, 2019

ooof you really think ahead :)

I guess this is a case then of extending the default parameters. Depending on if the Python release cycle will be shortened or not after 3.8 we have about 12 to 18 months time to get this sorted :)

@asottile
Copy link
Member Author

@asottile asottile commented Jul 20, 2019

I set up a ppa with the version bumped so we can start trying this out today -- https://launchpad.net/~asottile/+archive/ubuntu/python3.10

there's quite a lot of breakage unfortunately -- for example we can't really start fixing this much here until virtualenv is fixed: pypa/virtualenv#1385

source here: https://github.com/asottile/python3.10

a repackage of cpython master on 2019-07-17 with the minor version bumped to 3.10

why do this?

there's a significant amount of code which uses sys.version[:3] which will incorrectly report this as version 3.1 -- let's fix this long before it's a problem!

@gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented Jul 20, 2019

Virtualenv rewrite in progress will solve this mostly (including tox side)👍would not worry about this for now.

@asottile
Copy link
Member Author

@asottile asottile commented Jul 20, 2019

I don't think it will, we currently don't detect py310 as a python factor at all -- and even if we did it seems ambiguous between 3.1.0 3.10 31.0 etc.

@asottile
Copy link
Member Author

@asottile asottile commented Jul 20, 2019

Ideally I'd like to fix this now as it unlocks being able to test the rest of the ecosystem -- no virtualenv / no tox and it's really difficult to validate things

@gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented Jul 20, 2019

Part of the rewrite tox will delegate environment creation related stuff to virtualenv. Wait one more month 👍

@gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented Jul 20, 2019

If you really want go ahead though but fyi 😊

@asottile
Copy link
Member Author

@asottile asottile commented Jul 20, 2019

hehe I would appreciate a 16.6.3 w/ pypa/virtualenv#1385

@helpr helpr bot added the pr-available label Jul 25, 2019
@helpr helpr bot added pr-merged and removed pr-available labels Jul 27, 2019
@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants