Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox -p without number should enable auto mode #1418

Closed
ssbarnea opened this issue Sep 9, 2019 · 4 comments · Fixed by #1559
Closed

tox -p without number should enable auto mode #1418

ssbarnea opened this issue Sep 9, 2019 · 4 comments · Fixed by #1559
Labels
feature:new pr-merged

Comments

@ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Sep 9, 2019

It would a good improvement in user experience if when adding just -p, tox would run in parallel mode, like it does not with tox -p auto. This would save 5 keystrokes when calling tox.

I think that auto is likely what most people want when they want to run in parallel, so why to ask the to type more for getting it.

@ssbarnea ssbarnea added the feature:new label Sep 9, 2019
@awecx
Copy link

@awecx awecx commented Jan 12, 2020

This would be consistent with makefile -j where, if no argument is given, make would select a number of parallel recipes to build, by itself.

@JulienPalard
Copy link

@JulienPalard JulienPalard commented Jan 17, 2020

This would be consistent with makefile -j where, if no argument is given, would select a number of parallel recipes to build itself.

I'm not sure for every make implemn, but quoting the GNU make manpage:

If the -j option is given without an argument, make will not limit the number of jobs that can run simultaneously.

Which looks more like all than auto.

(This typically make make -j a bit violent when compiling cpython.)

I'd say all is not a sane default, and defaulting to auto looks a better choice.

While thinking about it, I bet (it's only a bet, so don't mind me) auto can be faster than all as both run the same quantity of instructions, but in the all case there may be more context switches (or worse, swapping).

@gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented Apr 19, 2020

Feel free to open a PR against master and fix it. My available efforts at the moment are aimed at fixing this as part of #1394, but that probably will take a while (ETA September).

@gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented May 2, 2020

Hello, this now has been released via https://pypi.org/project/tox/3.15.0/

heads up

@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature:new pr-merged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants