Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to bypass package installation on demand #1605

Closed
gaborbernat opened this issue Jun 26, 2020 · 2 comments · Fixed by #1606
Closed

Option to bypass package installation on demand #1605

gaborbernat opened this issue Jun 26, 2020 · 2 comments · Fixed by #1606
Labels
feature:new pr-merged

Comments

@gaborbernat
Copy link
Member

gaborbernat commented Jun 26, 2020

Currently if you want to separate tox setup and run via:

tox -e py --notest
tox -e py

The second invocation still builds the package and installs it. I suggest adding --skip-package-install that would skip this step and go ahead straight with running the test suite? (especially useful in CIs to avoid the redundant rebuild and install) @asottile what you think?

@gaborbernat gaborbernat added the feature:new label Jun 26, 2020
@asottile
Copy link
Member

asottile commented Jun 26, 2020

option seems fine, it'd be safer if it validated that the package was already installed

@gaborbernat
Copy link
Member Author

gaborbernat commented Jun 26, 2020

Any cheap validation methods here though? 🤔 I'm not sure I can think of something that does not involve calling out to pip via subprocess which is not always cheap 🤔 and finding out the package name similarly can be expensive unless we start caching the built package names... which then involves more complication (though would be easier in tox 4, where we have better-caching system in-place). So, for now, I'm tempted to go ahead with no validation and make it use with caution flag.

@helpr helpr bot added the pr-available label Jun 26, 2020
@helpr helpr bot added pr-merged and removed pr-available labels Jun 26, 2020
@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature:new pr-merged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants