New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox --installpkg raises an AttributeError #235

Closed
pytoxbot opened this Issue Sep 17, 2016 · 3 comments

Comments

Projects
None yet
1 participant
@pytoxbot

pytoxbot commented Sep 17, 2016

tox --installpkg dist/something.tgz raises an attributeerror:

#!python

Traceback (most recent call last):
  File "/Users/mvantellingen/virtualenvs/something/bin/tox", line 9, in <module>
    load_entry_point('tox==1.8.0', 'console_scripts', 'tox')()
  File "/Users/mvantellingen/virtualenvs/something/lib/python2.7/site-packages/tox/_cmdline.py", line 26, in main
    retcode = Session(config).runcommand()
  File "/Users/mvantellingen/virtualenvs/something/lib/python2.7/site-packages/tox/_cmdline.py", line 310, in runcommand
    return self.subcommand_test()
  File "/Users/mvantellingen/virtualenvs/something/lib/python2.7/site-packages/tox/_cmdline.py", line 454, in subcommand_test
    self.installpkg(venv, sdist_path)
  File "/Users/mvantellingen/virtualenvs/something/lib/python2.7/site-packages/tox/_cmdline.py", line 397, in installpkg
    self.resultlog.set_header(installpkg=sdist_path)
  File "/Users/mvantellingen/virtualenvs/something/lib/python2.7/site-packages/tox/result.py", line 21, in set_header
    md5=installpkg.computehash("md5"),
AttributeError: 'str' object has no attribute 'computehash'

@pytoxbot

This comment has been minimized.

Show comment
Hide comment
@pytoxbot

pytoxbot Sep 17, 2016

Original comment by @hpk42

Merged in wmyll6/tox/issue-235-fix-installpkg (pull request #146)

fix issue #235, --installpkg is broken

→ <<cset 71ea3fac1a1d>>

pytoxbot commented Sep 17, 2016

Original comment by @hpk42

Merged in wmyll6/tox/issue-235-fix-installpkg (pull request #146)

fix issue #235, --installpkg is broken

→ <<cset 71ea3fac1a1d>>

1 similar comment
@pytoxbot

This comment has been minimized.

Show comment
Hide comment
@pytoxbot

pytoxbot Sep 17, 2016

Original comment by @hpk42

Merged in wmyll6/tox/issue-235-fix-installpkg (pull request #146)

fix issue #235, --installpkg is broken

→ <<cset 71ea3fac1a1d>>

pytoxbot commented Sep 17, 2016

Original comment by @hpk42

Merged in wmyll6/tox/issue-235-fix-installpkg (pull request #146)

fix issue #235, --installpkg is broken

→ <<cset 71ea3fac1a1d>>

@pytoxbot

This comment has been minimized.

Show comment
Hide comment
@pytoxbot

pytoxbot Sep 17, 2016

Original comment by @hpk42

fix issue #235, --installpkg is broken

Problem

Session result log requires py.path.local for the source distribution when setting header.
Passing str.

Testing

tox.ini configuration::

[testenv:X]
commands={posargs}

[testenv:Y]
commands={posargs}

download sdist

pip install -d . ranger

install with a newly built fox version

tox -e X -- tox -e Y --installpkg ranger-0.9.tar.gz --notest

→ <<cset 47b8e230f7b3>>

pytoxbot commented Sep 17, 2016

Original comment by @hpk42

fix issue #235, --installpkg is broken

Problem

Session result log requires py.path.local for the source distribution when setting header.
Passing str.

Testing

tox.ini configuration::

[testenv:X]
commands={posargs}

[testenv:Y]
commands={posargs}

download sdist

pip install -d . ranger

install with a newly built fox version

tox -e X -- tox -e Y --installpkg ranger-0.9.tar.gz --notest

→ <<cset 47b8e230f7b3>>

@pytoxbot pytoxbot closed this Sep 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment