New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use py.path._gethomedir in ci context #24

Closed
pytoxbot opened this Issue Sep 17, 2016 · 3 comments

Comments

3 participants
@pytoxbot

pytoxbot commented Sep 17, 2016

ci servers that run on win32 don't have a assigned homedir in the env

it makes sense to avoid using it there or generally making the substitution lazily calculated

@obestwalter

This comment has been minimized.

Member

obestwalter commented Dec 21, 2016

@RonnyPfannschmidt I am pretty sure that has been solved on one or other way in the meantime and can be closed. Correct?

@RonnyPfannschmidt

This comment has been minimized.

Contributor

RonnyPfannschmidt commented Dec 22, 2016

no idea, please verify, its likely its not fixed

@obestwalter

This comment has been minimized.

Member

obestwalter commented Sep 4, 2017

This was fixed by simply catching any exception that might occur fetching the homedir ...

tox/tox/config.py

Lines 680 to 684 in e8891a5

def get_homedir():
try:
return py.path.local._gethomedir()
except Exception:
return None

@obestwalter obestwalter closed this Sep 4, 2017

@obestwalter obestwalter added this to do not add to CHANGELOG in [released] 3.0.x Sep 6, 2017

@obestwalter obestwalter added this to no changelog in [released] 2.9.x Sep 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment