Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass through *_proxy environment variables by default #258

Closed
pytoxbot opened this issue Sep 17, 2016 · 2 comments
Closed

Pass through *_proxy environment variables by default #258

pytoxbot opened this issue Sep 17, 2016 · 2 comments

Comments

@pytoxbot
Copy link

@pytoxbot pytoxbot commented Sep 17, 2016

Inside corporations is quite common being working beside a proxy. In Linux some applications (like pip) takes proxy configuration from following environment variables:

http_proxy https_proxy no_proxy
HTTP_PROXY HTTPS_PROXY NO_PROXY

Being variables of the system and quite standard and not being specific of projects, I think they should be passed through by default.

@pytoxbot
Copy link
Author

@pytoxbot pytoxbot commented Sep 17, 2016

Original comment by @hpk42

with https://bitbucket.org/hpk42/tox/commits/521459223e524337d187ef07277f0ee1485cd313 all env variables are passed through now.

@pytoxbot
Copy link
Author

@pytoxbot pytoxbot commented Sep 17, 2016

Original comment by @stefano-m

I think it makes sense. Windows systems may benefit too as some applications (e.g. git or node) honor the proxy environment variables when they're set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.