Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substitution key not found error with complex factor conditions and references #302

Closed
pytoxbot opened this issue Sep 17, 2016 · 4 comments
Closed

Comments

@pytoxbot
Copy link

@pytoxbot pytoxbot commented Sep 17, 2016

Consider the following tox.ini file:

#!ini
[tox]
envlist = py27,py34

[testenv]
deps =
  py{27,34}: foo

[testenv:docs]
deps = {[testenv]deps}

Running any tox command raises an error:

tox.ConfigError: ConfigError: substitution key '27,34' not found
@pytoxbot
Copy link
Author

@pytoxbot pytoxbot commented Sep 17, 2016

Original comment by @hpk42

add changelog entry: fix issue302: allow cross-testenv substitution where we substitute
with {x,y} generative syntax. Thanks Andrew Pashkin.

→ <<cset 581a1b974cd2>>

@pytoxbot pytoxbot closed this Sep 17, 2016
@pytoxbot
Copy link
Author

@pytoxbot pytoxbot commented Sep 17, 2016

Original comment by @hpk42

Merged in andrew_pashkin/tox/issue302 (pull request #207)

Make substitution engine ignore factor arrays, fix #302

→ <<cset 9071df77a7fd>>

1 similar comment
@pytoxbot
Copy link
Author

@pytoxbot pytoxbot commented Sep 17, 2016

Original comment by @hpk42

Merged in andrew_pashkin/tox/issue302 (pull request #207)

Make substitution engine ignore factor arrays, fix #302

→ <<cset 9071df77a7fd>>

@pytoxbot
Copy link
Author

@pytoxbot pytoxbot commented Sep 17, 2016

Original comment by @hpk42

Make substitution engine ignore factor arrays, fix #302

The fix assumes, that the bug was that the substitution engine -
tox.config.Replacer, while recursvely replacing references to actual
values, treated factor arrays (like {py27,py34}) as references, that
are needed to be replaced, which they are not.

The patch simply amends regex which is used by Replacer to recognize
references, to ignore factor arrays. And factor arrays assumed to be
values, enclosed in curly braces, that contain at least one comma.

→ <<cset 66b0272bf19e>>

RonnyPfannschmidt pushed a commit that referenced this issue Sep 17, 2016
The fix assumes, that the bug was that the substitution engine -
tox.config.Replacer, while recursvely replacing references to actual
values, treated factor arrays (like {py27,py34}) as references, that
are needed to be replaced, which they are not.

The patch simply amends regex which is used by Replacer to recognize
references, to ignore factor arrays. And factor arrays assumed to be
values, enclosed in curly braces, that contain at least one comma.

--HG--
branch : issue302
RonnyPfannschmidt pushed a commit that referenced this issue Sep 17, 2016
Make substitution engine ignore factor arrays, fix #302
@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant