Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox command busted on Windows #314

Closed
pytoxbot opened this issue Sep 17, 2016 · 4 comments
Closed

tox command busted on Windows #314

pytoxbot opened this issue Sep 17, 2016 · 4 comments

Comments

@pytoxbot
Copy link

@pytoxbot pytoxbot commented Sep 17, 2016

The tox command on Windows is busted due to the changes made by @hpk42 in https://bitbucket.org/hpk42/tox/commits/0823f359a05bde1d8f12f02e98b6b3a26d83c2b2

In detail it is this change:

  •            newargs = [str(self.venv.getcommandpath())] + newargs
    
  •            newargs = [str(self.envconfig.envpython)] + newargs
    

envconfig is not a property of the Action class, so changing it to the following will fix it:

newargs = [str(self.venv.envconfig.envpython)] + newargs

Here the traceback:

Traceback (most recent call last):
File "c:\python27\lib\runpy.py", line 162, in run_module_as_main
"main", fname, loader, pkg_name)
File "c:\python27\lib\runpy.py", line 72, in run_code
exec code in run_globals
File "C:\Python27\Scripts\tox.exe__main
.py", line 9, in
File "c:\python27\lib\site-packages\tox\session.py", line 39, in main
retcode = Session(config).runcommand()
File "c:\python27\lib\site-packages\tox\session.py", line 375, in runcommand
return self.subcommand_test()
File "c:\python27\lib\site-packages\tox\session.py", line 548, in subcommand_test
self.runtestenv(venv)
File "c:\python27\lib\site-packages\tox\session.py", line 556, in runtestenv
venv.test(redirect=redirect)
File "c:\python27\lib\site-packages\tox\venv.py", line 332, in test
ignore_ret=ignore_ret, testcommand=True)
File "c:\python27\lib\site-packages\tox\venv.py", line 362, in _pcall
redirect=redirect, ignore_ret=ignore_ret)
File "c:\python27\lib\site-packages\tox\session.py", line 136, in popen
stdout=stdout, stderr=STDOUT)
File "c:\python27\lib\site-packages\tox\session.py", line 219, in _popen
args = self._rewriteargs(cwd, args)
File "c:\python27\lib\site-packages\tox\session.py", line 214, in _rewriteargs
newargs = [str(self.envconfig.envpython)] + newargs
AttributeError: 'Action' object has no attribute 'envconfig'
Command exited with code 1

@pytoxbot
Copy link
Author

@pytoxbot pytoxbot commented Sep 17, 2016

Original comment by @hpk42

oh, and if you want to help to get more focus during the upcoming python testing sprint on tox, here is your opportunity :) https://www.indiegogo.com/projects/python-testing-sprint-mid-2016/x/4034848#/

@pytoxbot
Copy link
Author

@pytoxbot pytoxbot commented Sep 17, 2016

Original comment by @hpk42

you can try to install the release candidate http://devpi.local/fschulze/devpi3/+f/1aa/9e059e7dfeca4/tox-2.3.2.tar.gz#sha256=1aa9e059e7dfeca455f88e8259c2cd057eeffa4c8e388e8555cd4781c6c248a8 -- but i am not going to release it because i could only fix things from next thursday on.

@pytoxbot
Copy link
Author

@pytoxbot pytoxbot commented Sep 17, 2016

Original comment by @whimboo

Thank you for the quick fix. Would it be possible to get a new version released to pypi? That would be fantastic.

@pytoxbot pytoxbot closed this Sep 17, 2016
@pytoxbot
Copy link
Author

@pytoxbot pytoxbot commented Sep 17, 2016

Original comment by @hpk42

fix issue314: fix invocation of .py scripts on windows

→ <>

@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant