Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add testenv-configuration for installer command #35

Closed
pytoxbot opened this issue Sep 17, 2016 · 7 comments
Closed

add testenv-configuration for installer command #35

pytoxbot opened this issue Sep 17, 2016 · 7 comments

Comments

@pytoxbot
Copy link

@pytoxbot pytoxbot commented Sep 17, 2016

pip and easy_install both support --find-links as an alternative to using an index server.

we use --find-link stores at my company to store our local distributions.

as it is, to use tox, we have to add the findlink directives to the pip config for the user account running tox.

instead of just adding options to pip/easy_install one by one you could consider just offering an "advanced" option to allow users to construct their own pip/easy_install commands in the config.

@pytoxbot
Copy link
Author

@pytoxbot pytoxbot commented Sep 17, 2016

Original comment by @hpk42

tox was released already as 1.6.1 and includes @carljm 's install_command which should help using --find-links etc.

@pytoxbot
Copy link
Author

@pytoxbot pytoxbot commented Sep 17, 2016

Original comment by @carljm

I filed pull request 61 with a first pass at this.

@pytoxbot
Copy link
Author

@pytoxbot pytoxbot commented Sep 17, 2016

Original comment by @hpk42

@carljm if you need help, let me know (on IRC or here).

@pytoxbot
Copy link
Author

@pytoxbot pytoxbot commented Sep 17, 2016

Original comment by @hpk42

Issue #106 was marked as a duplicate of this issue. It discussed using wheel-options and i think the upcoming support for custom install commands should support it.

@pytoxbot
Copy link
Author

@pytoxbot pytoxbot commented Sep 17, 2016

Original comment by @carljm

Sounds good, thanks, I'll see if I can get a pull request in this week.

@pytoxbot
Copy link
Author

@pytoxbot pytoxbot commented Sep 17, 2016

Original comment by @hpk42

Hi Carl. OK, let's go for customizing installation commands. I think we need both one for "installer_deps" and "installer_package". Both should be [testenv*] variables. A PR also requires some docs and we may need to introduce a substituion-var to get access to the dependency name(s) and package location, respectively. I plan to do a 1.6 next week and am ready to review this week any proposed changes.

@pytoxbot
Copy link
Author

@pytoxbot pytoxbot commented Sep 17, 2016

Original comment by @carljm

I have a client with the same issue. @hpk42 can you offer any guidance on how you'd like to address it? I can put together a pull request either for an additional find-links tox option, or for a more general "construct your own pip command line" option. I lean towards the latter.

@pytoxbot pytoxbot closed this Sep 17, 2016
@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant