New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `LANGUAGE` env var to default pass list #431

Closed
ulope opened this Issue Dec 29, 2016 · 9 comments

Comments

Projects
None yet
3 participants
@ulope

ulope commented Dec 29, 2016

Since tox 2.0.2 LANG is automatically passed to avoid Unicode(En|De)codeErrors. I've just now encountered a system (macOS) where LANGUAGE was used instead of LANG, again causing test breakage.

I would suggest to add LANGUAGE to the list of default pass variables.

@obestwalter

This comment has been minimized.

Member

obestwalter commented Dec 29, 2016

Thanks for the report @ulope. Is that maybe a special configuration? I don't have a Mac here atm, but AFAIK mac uses the same LANG env vars like other UNIXES and Linux. Are there some official docs about this?

@ulope

This comment has been minimized.

ulope commented Dec 29, 2016

Yeah I hadn't seen it before either.
According to man 7 locale it applies to LC_MESSAGES.

It does affect Python's string handling however so I still think it would make sense to add it to the default "pass" list.

@pawelad

This comment has been minimized.

Contributor

pawelad commented Feb 26, 2017

Is anyone working on this feature?

@obestwalter

This comment has been minimized.

Member

obestwalter commented Feb 26, 2017

Not that I know of. Go for it :)

@pawelad

This comment has been minimized.

Contributor

pawelad commented Mar 8, 2017

Should LANGUAGE be always allowed on both Unix and OS X or only on OS X?

@obestwalter

This comment has been minimized.

Member

obestwalter commented Mar 8, 2017

AFAIK it's not used on Debian based systems. I'm on Arch Linux and there is also no LANGUAGE, so I would tend to say it's a Mac specific adjustment. It would be great if you could do some additional research about this before proposing an implementation.

@ulope

This comment has been minimized.

ulope commented Mar 9, 2017

It appears to be a standard feature: https://linux.die.net/man/7/locale (see section on LC_MESSAGES)

@pawelad

This comment has been minimized.

Contributor

pawelad commented Mar 18, 2017

It's not set on my OS X or my Ubuntu 16.04 but it is in the locale manual so I think it should be safe to add it.

@pawelad

This comment has been minimized.

Contributor

pawelad commented Mar 18, 2017

Pull request: #486

obestwalter added a commit that referenced this issue Mar 25, 2017

Merge pull request #486 from pawelad/431/add-LANGUAGE-to-default-passenv
Add 'LANGUAGE' to default passed environment variables (#431)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment