New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please state explicit dependencies #46

Closed
pytoxbot opened this Issue Sep 17, 2016 · 5 comments

Comments

Projects
None yet
1 participant
@pytoxbot

pytoxbot commented Sep 17, 2016

It appears that tox (or at least the test phase) also depends on pytest and pip. Please make this explicit in the setup.py (and preferably also in the installation docs) to make life easier for packagers.

@pytoxbot

This comment has been minimized.

pytoxbot commented Sep 17, 2016

Original comment by @hpk42

add "py" environment using sys.executable and tox's python setup.py test
execute tox with -e py. (closes #46)

→ <>

@pytoxbot

This comment has been minimized.

pytoxbot commented Sep 17, 2016

Original comment by @djc

Perhaps you could just add a comment that test dependencies are listed in tox.ini? This is just about making it easiers for packagers to find all the required dependencies to properly run the test suite (I've failed so far).

@pytoxbot

This comment has been minimized.

pytoxbot commented Sep 17, 2016

Original comment by @hpk42

but even with test_requires you couldn't run the tests with setup.py tests - do you still want to have the deps listet here? (i don't really mind, it's just not useful too me and needs attention to keep in sync with tox.ini)

@pytoxbot

This comment has been minimized.

pytoxbot commented Sep 17, 2016

Original comment by @djc

It would be nice to also include the dependencies in test_requires in setup.py... tox.ini is not as standard (yet, at least!).

@pytoxbot

This comment has been minimized.

pytoxbot commented Sep 17, 2016

Original comment by @hpk42

Hum, the tox.ini states the depedencies for running the tests. Not enough?

@pytoxbot pytoxbot closed this Sep 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment