Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upComments
AndreLouisCaron
referenced this issue
May 18, 2017
Merged
Forward NUMBER_OF_PROCESSORS by default on Windows #520
This comment has been minimized.
This comment has been minimized.
|
Hi @AndreLouisCaron We have a growing list of special cases and for one think that your argument that tox should work out of the box with standard library is a compelling one, to add that also. |
obestwalter
added
the
enhancement
label
Jun 30, 2017
obestwalter
closed this
Jun 30, 2017
obestwalter
moved this from finalize
to done
in [released]2.8.x
Jul 2, 2017
This was referenced Jul 2, 2017
Closed
obestwalter
moved this from finalize
to done
in [released]2.8.x
Jul 14, 2017
This was referenced Sep 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
AndreLouisCaron commentedMay 18, 2017
Hi there!
In one project, I have a Python 2.7-only dependency that uses
multiprocessing.cpu_count()on Windows. This has a hidden dependency on theNUMBER_OF_PROCESSORSenvironment variable. This is quite confusing when porting this type of project into Tox.Note: in Python 3.4+, this is API is superseeded by
os.cpu_count()which does not depend on this environment variable.The case is a bit weak (Python up to 3.3 only, plus multiprocessing is not popular on Windows), but I feel like the standard library should work by default inside a Tox test environment.
I'm willing to work on a patch if you would accept such a contribution!