Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let skip_install override usedevelop instead of the other way around #571

Closed
obestwalter opened this issue Aug 9, 2017 · 2 comments · Fixed by #572
Closed

Let skip_install override usedevelop instead of the other way around #571

obestwalter opened this issue Aug 9, 2017 · 2 comments · Fixed by #572

Comments

@obestwalter
Copy link
Member

@obestwalter obestwalter commented Aug 9, 2017

skip_install and usedevelop can be used together in the same environment but the behaviour is not documented. If both flags are True the package will be installed although skip_install is requested (see also discussion here).

The behaviour should be changed that skip_install overrides usedevelop as usedevelop is an option to choose the installation type if the package is installed and skip_install determines if it should be installed at all.

This is a somewhat breaking change of undocumented behaviour but I think this should be done to make the behaviour intuitively correct (but it should also be documented).

It should be also stated prominently in the changelog that this changed and how it can be fixed though. The documentation should be updated mention the behaviour when these two flags are used together.

@obestwalter
Copy link
Member Author

@obestwalter obestwalter commented Sep 7, 2017

docs still needed.

@obestwalter obestwalter reopened this Sep 7, 2017
@gaborbernat gaborbernat added this to the 3.5 milestone Sep 18, 2018
@gaborbernat gaborbernat removed this from the 3.5 milestone Oct 8, 2018
@gaborbernat gaborbernat added this to the 3.6 milestone Oct 8, 2018
@gaborbernat gaborbernat removed this from the 3.6 milestone Oct 8, 2018
@gaborbernat gaborbernat removed this from the 3.6 milestone Oct 8, 2018
@gaborbernat gaborbernat added this to the 3.6 milestone Oct 8, 2018
@gaborbernat gaborbernat removed this from the 3.6 milestone Dec 16, 2018
@gaborbernat gaborbernat added this to the 3.7 milestone Dec 16, 2018
@gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented Jan 13, 2022

This has been done with tox 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants