Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$HOME does not always equal ~$USER #60

Closed
pytoxbot opened this issue Sep 17, 2016 · 2 comments
Closed

$HOME does not always equal ~$USER #60

pytoxbot opened this issue Sep 17, 2016 · 2 comments

Comments

@pytoxbot
Copy link

@pytoxbot pytoxbot commented Sep 17, 2016

There's a test in test_config.py that essentially expects $HOME to be equal to ~$USER. This is not the case in certain build environments (e.g. sbuild for Debian/Ubuntu, which explicitly sets $HOME to a non-existent directory). I have changed the test to check against $HOME instead, which may be pointless but I couldn't come up with anything more reasonable.

Note too that the tests essentially require $HOME exists, otherwise the test suite crashes. Maybe that's also a bug.

@pytoxbot
Copy link
Author

@pytoxbot pytoxbot commented Sep 17, 2016

Original comment by @hpk42

fixed test to not rely on os.path.expanduser (closes #60)

thanks Barry. I committed a variation that also works on windows i think.

→ <<cset 1e43ca7d5617>>

@pytoxbot pytoxbot closed this Sep 17, 2016
@pytoxbot
Copy link
Author

@pytoxbot pytoxbot commented Sep 17, 2016

Original comment by @warsaw

Here's the patch I'm using

@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant