New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test incorrectly includes argv[0] #61

Closed
pytoxbot opened this Issue Sep 17, 2016 · 2 comments

Comments

Projects
None yet
1 participant
@pytoxbot

pytoxbot commented Sep 17, 2016

One of the tests in test_venv.py fails because in fact "-i" does appear in argv[0]. Since argv[0] could be anything (I think), it makes sense to filter this out of the string being tested.

I'll attach a patch, but it's possible that more call sites which test .args should also filter out argv[0].

@pytoxbot

This comment has been minimized.

Show comment
Hide comment
@pytoxbot

pytoxbot Sep 17, 2016

Original comment by @hpk42

fix #61 - always pass args[1:] from the mock-call

→ <<cset 5c050a61adc5>>

pytoxbot commented Sep 17, 2016

Original comment by @hpk42

fix #61 - always pass args[1:] from the mock-call

→ <<cset 5c050a61adc5>>

@pytoxbot

This comment has been minimized.

Show comment
Hide comment
@pytoxbot

pytoxbot Sep 17, 2016

Original comment by @warsaw

pytoxbot commented Sep 17, 2016

Original comment by @warsaw

@pytoxbot pytoxbot closed this Sep 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment