Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

followup to #662 - Fix E741 (flake8) #663

Closed
asottile opened this issue Oct 26, 2017 · 3 comments
Closed

followup to #662 - Fix E741 (flake8) #663

asottile opened this issue Oct 26, 2017 · 3 comments

Comments

@asottile
Copy link
Member

@asottile asottile commented Oct 26, 2017

I've temporarily turned this off in #662 such that we can get our build back to green.

We should go through and fix E741 (ambiguous variable name) -- the variable name in question appears to be l (and I agree, I have no idea what it means!)

@obestwalter
Copy link
Member

@obestwalter obestwalter commented Nov 5, 2017

ah, that's new and I guess it is there because l and 1 can be confused if you use a bad font or something.

@cryvate
Copy link
Contributor

@cryvate cryvate commented Nov 8, 2017

I am happy to have a look at this if no-one is working on it yet?

@asottile
Copy link
Member Author

@asottile asottile commented Nov 8, 2017

Go for it!

gaborbernat added a commit that referenced this issue Nov 11, 2017
* Fix pycodestyle (formerly pep8) errors E741 (ambiguous variable names, in this case, 'l's) and remove ignore of this error in tox.ini
@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants