New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--result-json does not respect --skip-missing-interpreters-option #672

Closed
r2dan opened this Issue Nov 15, 2017 · 2 comments

Comments

Projects
2 participants
@r2dan
Contributor

r2dan commented Nov 15, 2017

When executing tox with --result-json and --skip-missing-interpreters-option, the latter seems not to be reflected in the generated json file. Please find the sample project attached below:
missing_interpreters.tar.gz

To reproduce the issue simply invoke:

tox --skip-missing-interpreters --result-json toxreport.json
Tox main process exits with return code 0, but in toxreport.json file user can see the following:

"python": {
  "setup": [
  {
    "command": [
    "setup virtualenv"
    ],
    "output": "InterpreterNotFound: xyz_unknown_interpreter",
    "retcode": "1"
   }
   ]
}

In my opinion retcode here should be changed to 0 if --skip-missing-interpreters option is explicitly used.

@r2dan r2dan changed the title from --result-log does not respect --skip-missing-interpreters-option to --result-json does not respect --skip-missing-interpreters-option Nov 15, 2017

@obestwalter

This comment has been minimized.

Member

obestwalter commented Nov 17, 2017

Hi @r2dan thanks for the report. Having a test reproducing this would also be great.

@r2dan

This comment has been minimized.

Contributor

r2dan commented Jan 5, 2018

Sorry for a long radio silence - the test (and PR) is ready. Thanks!

gaborbernat added a commit that referenced this issue Jan 11, 2018

Fix generation of JSON files with --skip-missing-interpreters option. F…
…ixes #672  (#726)

* Fix generation of JSON files with --skip-missing-interpreters option.

* reverting accidental formatting change

@obestwalter obestwalter added this to issues in [released] 3.0.x Jan 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment