Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add support for envreport action to be pluggable #725

Closed
tonybaloney opened this issue Jan 5, 2018 · 2 comments
Closed

[FEATURE] Add support for envreport action to be pluggable #725

tonybaloney opened this issue Jan 5, 2018 · 2 comments

Comments

@tonybaloney
Copy link
Contributor

@tonybaloney tonybaloney commented Jan 5, 2018

Requesting (and willing to submit a PR) that the plugin system support a hookimpl for the envreport action.

I'm developing a plugin for Pipenv https://github.com/tonybaloney/tox-pipenv using the hook implementation API in 2.9.1.

So far it's working nicely, however as stated in the docs, the hook implementation options are not complete.

Whilst the default option for list_dependencies_command can be overridden at runtime, I want the plugin to be self-contained. Also, setting the configuration option when the plugin ignores it seems a little obtuse.

https://github.com/tox-dev/tox/blob/master/tox/config.py#L595-L599

tonybaloney added a commit to tonybaloney/tox that referenced this issue Jan 8, 2018
@tonybaloney
Copy link
Contributor Author

@tonybaloney tonybaloney commented Jan 8, 2018

Raised PR with potential implementation

@asottile
Copy link
Member

@asottile asottile commented Jan 8, 2018

I think you can do this without needing new apis. For example, here's how tox-pip-extensions sets the install_cmd: https://github.com/tox-dev/tox-pip-extensions/blob/a989ec95ef8f3c5e63bb809308cd4260f0690e76/tox_pip_extensions.py#L71

gaborbernat added a commit that referenced this issue Jan 24, 2018
* add a plugin for reporting on the package versions in a venv. see #725
* changelog entry for #725
* fix lint issue
* add docstring comment on expected response
@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants