New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox.cmdline() fails on 3.0.0rc2 but works in 2.9.1 #773

Closed
Jerhaad opened this Issue Mar 12, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@Jerhaad

Jerhaad commented Mar 12, 2018

We use this functionality in a lot of our tools and I'm not seeing anything about this in the changelog/documentation.

$ python
Python 3.6.3 (v3.6.3:2c5fed86e0, Oct  3 2017, 00:32:08)
[GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import tox
>>> tox.cmdline()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: main() missing 1 required positional argument: 'args'
>>>
$ pip list
pip (9.0.1)
pluggy (0.6.0)
py (1.5.2)
setuptools (38.5.2)
six (1.11.0)
tox (3.0.0rc2)
virtualenv (15.1.0)
wheel (0.30.0)

Mac OS X 10.12.6

@gaborbernat

This comment has been minimized.

Member

gaborbernat commented Mar 13, 2018

@Jerhaad thanks for the report, seems we should import run_main instead of main here https://github.com/tox-dev/tox/blob/master/tox/__init__.py#L87

@obestwalter

This comment has been minimized.

Member

obestwalter commented Mar 13, 2018

Thanks @Jerhaad - good, I start to believe in the power of the rc :)

@gaborbernat - you assigned yourself, so I'll check when this is fixed and release the hopefully last rc. I would also suggest to not merge anything else then anymore until 3.0 is released.

gaborbernat added a commit to gaborbernat/tox that referenced this issue Mar 16, 2018

gaborbernat added a commit to gaborbernat/tox that referenced this issue Mar 16, 2018

gaborbernat added a commit to gaborbernat/tox that referenced this issue Mar 16, 2018

gaborbernat added a commit to gaborbernat/tox that referenced this issue Mar 16, 2018

obestwalter added a commit that referenced this issue Mar 22, 2018

obestwalter added a commit to Avira/tox that referenced this issue Mar 22, 2018

obestwalter added a commit to Avira/tox that referenced this issue Mar 22, 2018

gaborbernat added a commit to gaborbernat/tox that referenced this issue Mar 23, 2018

gaborbernat added a commit to gaborbernat/tox that referenced this issue Mar 23, 2018

obestwalter added a commit that referenced this issue Mar 23, 2018

obestwalter added a commit that referenced this issue Mar 23, 2018

#773 allow cmdline to be called bot with and without args, make args …
…use sys.args if not specified (#777)

(cherry picked from commit 83f9a62)

@obestwalter obestwalter closed this Apr 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment