Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commands_pre/commands_post documentation. #1071

Merged
merged 1 commit into from Oct 24, 2018

Conversation

@benoit-pierre
Copy link
Contributor

@benoit-pierre benoit-pierre commented Oct 24, 2018

Mention the minimum version required.

Copy link
Member

@gaborbernat gaborbernat left a comment

The linting fails 😢

Mention the minimum version required.
@benoit-pierre
Copy link
Contributor Author

@benoit-pierre benoit-pierre commented Oct 24, 2018

Should be fixed.

@gaborbernat gaborbernat merged commit d6410eb into tox-dev:master Oct 24, 2018
2 checks passed
@gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented Oct 24, 2018

Thanks!

@benoit-pierre benoit-pierre deleted the patch-1 branch Oct 24, 2018
@cjerdonek
Copy link
Contributor

@cjerdonek cjerdonek commented Oct 24, 2018

Has there been any consideration of having tox issue a warning if unrecognized key values are encountered? That could help people to know they could need to upgrade. Currently, such key values (e.g. commands_pre) are silently skipped if the user doesn't have a new enough version.

@gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented Oct 24, 2018

No, and probably we'll never have it. This would be backwards incompatible change. Note people can at the moment use empty keywords together with substitution to re-use fields, e.g.:

[testenv]
doc_python = python3

[testenv:doc_build]
basepython = {[testenv]doc_python}

[testenv:doc_build2]
basepython = {[testenv]doc_python}

If you depend on a feature that's only available under a given version you should specify it via the minversion https://tox.readthedocs.io/en/latest/config.html#conf-minversion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants