New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make windows interpreter lookup precedence more like posix #1087

Merged
merged 1 commit into from Nov 19, 2018

Conversation

Projects
None yet
2 participants
@asottile
Member

asottile commented Nov 19, 2018

Notably:

  • check the current sys.executable first

Thanks for contributing a pull request!

If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • (n/a) added/updated test(s)
  • (n/a) updated/extended the documentation
  • (n/a) added relevant issue keyword in message body (n/a)
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if pr has no issue: consider creating one first or change it to the pr number after creating the pr
    • "sign" fragment with "by @"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)
Make windows interpreter lookup precedence more like posix
Notably:
- check the current `sys.executable` first
@asottile

This comment has been minimized.

Member

asottile commented Nov 19, 2018

for context, I'm trying to play with travis-ci + windows -- hitting this because chocolatey bundles a (broken?) python2.7.exe: https://travis-ci.org/asottile-archive/pyupgrade/jobs/456770464

@asottile asottile merged commit e62846b into tox-dev:master Nov 19, 2018

0 of 2 checks passed

codeclimate 2 issues to fix
Details
tox ci #tox ci_20181119.01 failed
Details

@asottile asottile deleted the asottile:windows_python_precedence branch Nov 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment