From 8197eb6b3d608906f58d58ef8a7aea6f3e4cf980 Mon Sep 17 00:00:00 2001 From: Oliver Bestwalter Date: Tue, 8 Jan 2019 20:22:50 +0100 Subject: [PATCH 1/2] add warning that whitelisting is mandatory from tox 4 on --- src/tox/venv.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/tox/venv.py b/src/tox/venv.py index d3e9954c7..68a54439c 100755 --- a/src/tox/venv.py +++ b/src/tox/venv.py @@ -174,7 +174,8 @@ def _check_external_allowed_and_warn(self, path): " cmd: {}\n" " env: {}\n" "Maybe you forgot to specify a dependency? " - "See also the whitelist_externals envconfig setting.".format( + "See also the whitelist_externals envconfig setting.\n\n" + "DEPRECATION WARNING: this will be an error in tox 4 and above!".format( path, self.envconfig.envdir ) ) From bf7c1cd4d5353b93ead38e9cadf9eae8c6a9efbb Mon Sep 17 00:00:00 2001 From: Oliver Bestwalter Date: Tue, 8 Jan 2019 20:22:50 +0100 Subject: [PATCH 2/2] add warning that whitelisting is mandatory from tox 4 on --- docs/changelog/1129.deprecation.rst | 1 + 1 file changed, 1 insertion(+) create mode 100644 docs/changelog/1129.deprecation.rst diff --git a/docs/changelog/1129.deprecation.rst b/docs/changelog/1129.deprecation.rst new file mode 100644 index 000000000..f9915c19c --- /dev/null +++ b/docs/changelog/1129.deprecation.rst @@ -0,0 +1 @@ +Whitelisting of externals will be mandatory in tox 4: issue a deprecation warning as part of the already existing warning - by :user:`obestwalter`