Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-eALL should also include environment from envlist #1155

Merged
merged 1 commit into from Feb 5, 2019

Conversation

@goneri
Copy link
Contributor

@goneri goneri commented Feb 1, 2019

According to the --help output, -eALL should work against specified
environments (ALL selects all). However, the environments from the
envlist key were ignored if they were not associated with a section.

For instance, with:

[tox]
envlist = py{a,b}

No environment was selected, and the default python was used instead.
With this patch, tox with test both a and b.

@goneri goneri force-pushed the include_ALL branch 6 times, most recently from 60c505f to 66ba126 Feb 1, 2019
According to the `--help` output, `-eALL` should work against specified
environments (ALL selects all). However, the environments from the
envlist key were ignored if they were not associated with a section.

For instance, with:
```
[tox]
envlist = py{a,b}
```

No environment was selected, and the default `python` was used instead.
With this patch, `tox` with test both `a` and `b`.
@gaborbernat gaborbernat merged commit 76ad3e6 into tox-dev:master Feb 5, 2019
5 checks passed
@gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented Feb 5, 2019

seal of approval
Thanks!

@goneri
Copy link
Contributor Author

@goneri goneri commented Feb 6, 2019

Thanks for the quick review 👍 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants