Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set setup.cfg encoding #1212

Merged
merged 2 commits into from Mar 28, 2019
Merged

Set setup.cfg encoding #1212

merged 2 commits into from Mar 28, 2019

Conversation

@stanislavlevin
Copy link
Contributor

@stanislavlevin stanislavlevin commented Mar 28, 2019

Fixes: #1211

Fixes: tox-dev#1211
Signed-off-by: Stanislav Levin <slev@altlinux.org>
@gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented Mar 28, 2019

Can you detail what and where broke without this? Thanks!

@stanislavlevin
Copy link
Contributor Author

@stanislavlevin stanislavlevin commented Mar 28, 2019

Sure,

(Pdb) bt
  /usr/src/RPM/BUILD/python-module-tox-3.8.0/setup.py(18)<module>()
-> package_dir={"": "src"},
  /usr/lib/python2.7/site-packages/setuptools/__init__.py(145)setup()
-> _install_setup_requires(attrs)
  /usr/lib/python2.7/site-packages/setuptools/__init__.py(138)_install_setup_requires()
-> dist.parse_config_files(ignore_option_errors=True)
  /usr/lib/python2.7/site-packages/setuptools/dist.py(703)parse_config_files()
-> self._parse_config_files(filenames=filenames)
  /usr/lib/python2.7/site-packages/setuptools/dist.py(600)_parse_config_files()
-> (parser.read_file if six.PY3 else parser.readfp)(reader)
  /usr/lib64/python2.7/ConfigParser.py(324)readfp()
-> self._read(fp, filename)
> /usr/lib64/python2.7/ConfigParser.py(479)_read()
-> line = fp.readline()
(Pdb) fp
<_io.TextIOWrapper name='setup.cfg' encoding='ANSI_X3.4-1968'>
(Pdb) fp.readline()
*** UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 345: ordinal not in range(128)
(Pdb) 

@stanislavlevin
Copy link
Contributor Author

@stanislavlevin stanislavlevin commented Mar 28, 2019

setup.cfg contains Unicode symbols like:

author = Holger Krekel, Oliver Bestwalter, Bernát Gábor and others

@gaborbernat gaborbernat merged commit 41a4116 into tox-dev:master Mar 28, 2019
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants