Fix #1236 typos in isolated.py build method #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unmade
requested review from
asottile,
gaborbernat and
obestwalter
as code owners
gaborbernat
reviewed
Mar 30, 2019
unmade
changed the title
|
@gaborbernat Sure, I added a changelog and also opened an issue :) |
gaborbernat
requested changes
Mar 30, 2019
docs/changelog.rst
Outdated
| @@ -11,6 +11,15 @@ with advance notice in the **Deprecations** section of releases. | |||
|
|
|||
| .. towncrier release notes start | |||
|
|
|||
| v3.8.4 (2019-03-30) | |||
| ------------------- | |||
There was a problem hiding this comment.
eh, not here, see https://github.com/tox-dev/tox/blob/master/docs/changelog/examples.rst
|
The failing test is not related to your PR, feel free to add a skip for it (python 2, windows only). |
gaborbernat
reviewed
Mar 30, 2019
|
@gaborbernat Thanks for guiding me! What is the right way to skip failing test? Should I make changes to |
|
pytest skip decorator 👌 |
gaborbernat
approved these changes
Mar 30, 2019
gaborbernat
approved these changes
Mar 30, 2019
|
Thanks! 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, there!
There are typos in tox/package/builder/isolated.py making it impossible to install package with requirements in pyproject.toml
I've been using tox (3.7.0) with flit as a build backend. After upgrading to tox 3.8 I keep getting an error whenever try to run tox.
It seems like during refactoring there have been made some typos. I made two commits: