Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed result of tox_get_python_executable not being used to make virtualenvs #1301

Merged
merged 2 commits into from May 16, 2019

Conversation

@AWhetter
Copy link
Contributor

@AWhetter AWhetter commented May 15, 2019

The result of tox_get_python_executable hooks are again used to create the virtualenvs.

Fixes #1300

Copy link
Member

@gaborbernat gaborbernat left a comment

let's keep the lookup but we just override on the answer to keep the original, also add a test to validate this guarantee

@AWhetter
Copy link
Contributor Author

@AWhetter AWhetter commented May 16, 2019

Is this what you had in mind?

@gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented May 16, 2019

Do fix the Ci (run tox -e fix_lint), otherwise looks great.

@gaborbernat gaborbernat merged commit a8b34cc into tox-dev:master May 16, 2019
2 checks passed
@gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented May 16, 2019

Released via https://pypi.org/project/tox/3.11.1/, thanks for your contribution.

PyPI
tox is a generic virtualenv management and test command line tool

@AWhetter AWhetter deleted the fix_1300 branch May 17, 2019
@AWhetter
Copy link
Contributor Author

@AWhetter AWhetter commented May 17, 2019

Thank you so much for the fast feedback and fast release! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants