Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify behaviour if recreate is set to false (#1372) #1399

Merged
merged 3 commits into from Aug 18, 2019
Merged

clarify behaviour if recreate is set to false (#1372) #1399

merged 3 commits into from Aug 18, 2019

Conversation

@PJCampi
Copy link
Contributor

@PJCampi PJCampi commented Aug 18, 2019

Thanks for contributing a pull request!

If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with "by :user:<your username>"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)
@PJCampi
Copy link
Contributor Author

@PJCampi PJCampi commented Aug 18, 2019

fixes #1372

@gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented Aug 18, 2019

Can you fix the ci?

@PJCampi
Copy link
Contributor Author

@PJCampi PJCampi commented Aug 18, 2019

This should fix it hopefully. I did not know I needed a new line at the end of my changelog file.

@gaborbernat gaborbernat merged commit 2e2855a into tox-dev:master Aug 18, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants