Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the failing CI on master #1456

Merged
merged 2 commits into from Nov 13, 2019
Merged

fix the failing CI on master #1456

merged 2 commits into from Nov 13, 2019

Conversation

@gaborbernat
Copy link
Member

gaborbernat commented Nov 11, 2019

The PR also bumps the linter tool versions, and drop python3.4 as the CI no longer supports it.

@gaborbernat gaborbernat force-pushed the gaborbernat:ci branch 16 times, most recently from 30366ae to d055f8e Nov 11, 2019
Copy link
Member

asottile left a comment

@gaborbernat gaborbernat force-pushed the gaborbernat:ci branch 3 times, most recently from c8841b8 to 071e0a8 Nov 11, 2019
@gaborbernat gaborbernat force-pushed the gaborbernat:ci branch 3 times, most recently from fce443b to e2ca18c Nov 11, 2019
@gaborbernat gaborbernat changed the title fix fix the failing CI on master Nov 11, 2019
@gaborbernat gaborbernat force-pushed the gaborbernat:ci branch from e2ca18c to 9f760f2 Nov 13, 2019
@gaborbernat gaborbernat force-pushed the gaborbernat:ci branch 17 times, most recently from 4be5749 to c177d7e Nov 13, 2019
fix
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat force-pushed the gaborbernat:ci branch from c177d7e to 1c0fedb Nov 13, 2019
@todo

This comment has been minimized.

Copy link

todo bot commented Nov 13, 2019

process numbers work differently on pypy")

@pytest.mark.skipif(INFO.IS_PYPY, reason="TODO: process numbers work differently on pypy")
@pytest.mark.skipif(
"sys.platform == 'win32'", reason="triggering SIGINT reliably on Windows is hard"
)


This comment was generated by todo based on a TODO comment in 38fe5fc in #1456. cc @gaborbernat.
@todo

This comment has been minimized.

Copy link

todo bot commented Nov 13, 2019

process numbers work differently on pypy")

@pytest.mark.skipif(INFO.IS_PYPY, reason="TODO: process numbers work differently on pypy")
@pytest.mark.skipif(
"sys.platform == 'win32'", reason="triggering SIGINT reliably on Windows is hard"
)


This comment was generated by todo based on a TODO comment in 38fe5fc in #1456. cc @gaborbernat.
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat force-pushed the gaborbernat:ci branch from 38fe5fc to 0bc8aad Nov 13, 2019
@todo

This comment has been minimized.

Copy link

todo bot commented Nov 13, 2019

process numbers work differently on pypy")

@pytest.mark.skipif(INFO.IS_PYPY, reason="TODO: process numbers work differently on pypy")
@pytest.mark.skipif(
"sys.platform == 'win32'", reason="triggering SIGINT reliably on Windows is hard"
)


This comment was generated by todo based on a TODO comment in 0bc8aad in #1456. cc @gaborbernat.
@todo

This comment has been minimized.

Copy link

todo bot commented Nov 13, 2019

process numbers work differently on pypy")

@pytest.mark.skipif(INFO.IS_PYPY, reason="TODO: process numbers work differently on pypy")
@pytest.mark.skipif(
"sys.platform == 'win32'", reason="triggering SIGINT reliably on Windows is hard"
)


This comment was generated by todo based on a TODO comment in 0bc8aad in #1456. cc @gaborbernat.
@gaborbernat

This comment has been minimized.

Copy link
Member Author

gaborbernat commented Nov 13, 2019

That was long but succeeded 👍

@gaborbernat gaborbernat merged commit c85365e into tox-dev:master Nov 13, 2019
1 check passed
1 check passed
Timeline protection Timeline protection: Good to go
Details
@gaborbernat gaborbernat deleted the gaborbernat:ci branch Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.