Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use get_python_info for consistency and caching #1462

Merged
merged 2 commits into from Dec 2, 2019

Conversation

@blueyed
Copy link
Contributor

blueyed commented Nov 15, 2019

I've came across this when looking at the code - it obviously needs some cleanup, but passes all tests and got me a cache hit at least with a typical run. (IIRC it saves 0.2+s at least due to this).

Let me know if you like it and I/we can finish it.

@blueyed blueyed changed the title [WIP/RFC] use get_python_info for consistency and caching [RFC] use get_python_info for consistency and caching Nov 17, 2019
@obestwalter

This comment has been minimized.

Copy link
Member

obestwalter commented Nov 19, 2019

Thanks! Seems like a no brainer to me :)

Copy link
Member

gaborbernat left a comment

Looks good 👍

@blueyed blueyed changed the title [RFC] use get_python_info for consistency and caching use get_python_info for consistency and caching Nov 21, 2019
@blueyed

This comment has been minimized.

Copy link
Contributor Author

blueyed commented Nov 21, 2019

ok, added a changelog.

Copy link
Member

gaborbernat left a comment

thanks

@gaborbernat gaborbernat merged commit 6a74205 into tox-dev:master Dec 2, 2019
2 checks passed
2 checks passed
Timeline protection Timeline protection: Good to go
Details
tox ci #tox ci_20191121.01 succeeded
Details
@blueyed blueyed deleted the blueyed:get_python_info branch Dec 2, 2019
@gaborbernat

This comment has been minimized.

Copy link
Member

gaborbernat commented Dec 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.