Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix colouring on windows #1471

Merged
merged 1 commit into from Dec 2, 2019
Merged

fix colouring on windows #1471

merged 1 commit into from Dec 2, 2019

Conversation

@eine
Copy link
Contributor

eine commented Dec 2, 2019

Ref #1468

Currently, colorama is required in order to get coloured output on Windows, even if it is not used. This is because of:

https://github.com/pytest-dev/py/blob/1e99d20f31ef511fc2f1a9e49ba970acad441d4e/py/_io/terminalwriter.py#L16-L24

Since neither tox nor TerminalWriter do install colorama explicitly, it falls back to win32_and_ctypes, which does not work. In this PR, colorama is added to install_requires, for it to be installed on Windows only.

At first, I was not convinced about adding the dependency, because it is not required for minimal usage of tox (i.e., without colours). However, I saw that it will be included for all platforms in #1400, so I guess that it is acceptable.

1138-4EB 1138-4EB
@eine eine force-pushed the eine:fix-win-deps branch from 4aabc38 to d74236d Dec 2, 2019
@eine eine force-pushed the eine:fix-win-deps branch from d74236d to 484ad6c Dec 2, 2019
Copy link
Member

gaborbernat left a comment

thanks

@gaborbernat gaborbernat merged commit c420d01 into tox-dev:master Dec 2, 2019
1 of 2 checks passed
1 of 2 checks passed
tox ci #tox ci_20191202.04 failed
Details
Timeline protection Timeline protection: Good to go
Details
@eine eine deleted the eine:fix-win-deps branch Dec 2, 2019
@gaborbernat

This comment has been minimized.

Copy link
Member

gaborbernat commented Dec 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.