Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use latest version of importlib_metadata #1472

Merged
merged 1 commit into from Dec 2, 2019
Merged

Conversation

@kammala
Copy link
Contributor

kammala commented Dec 2, 2019

Since November 30 importlib_metadata uses semver and has latest version 1.1.0.

If you use twine or pytest(which do not pin upper bound of importlib_metadata dependency) and tox in the same virtualenv and check for package integrity with pip check, you can easily run into the trouble that python installs importlib_metadata incompatible with tox.

Thanks for contributing a pull request!

If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with "by :user:<your username>"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)
Copy link
Member

gaborbernat left a comment

thanks

@gaborbernat gaborbernat merged commit b4c4625 into tox-dev:master Dec 2, 2019
1 of 2 checks passed
1 of 2 checks passed
tox ci #tox ci_20191202.06 failed
Details
Timeline protection Timeline protection: Good to go
Details
@RonnyPfannschmidt

This comment has been minimized.

Copy link
Contributor

RonnyPfannschmidt commented Dec 2, 2019

@kammala thanks as well, i literally ran into this via devpi and its just great to come in and see something fixed right at that moment

@gaborbernat got an eta for a release?

@gaborbernat

This comment has been minimized.

Copy link
Member

gaborbernat commented Dec 2, 2019

will need to fix the first master on which I have no ETA 🤔 if anyone could assist 👍

@gaborbernat

This comment has been minimized.

Copy link
Member

gaborbernat commented Dec 2, 2019

@chyzzqo2

This comment has been minimized.

Copy link
Contributor

chyzzqo2 commented Dec 3, 2019

This pin seems too aggressive, why do we need >= 1.1.0 instead of > 0.12

@gaborbernat

This comment has been minimized.

Copy link
Member

gaborbernat commented Dec 3, 2019

Feels alright to me, why would this cause an issue? It's our runtime dependency.

@asottile

This comment has been minimized.

Copy link
Member

asottile commented Dec 3, 2019

I could understand the issue, when trying to install tox alongside something else you'll potentially get conflicts

@kammala

This comment has been minimized.

Copy link
Contributor Author

kammala commented Dec 3, 2019

Personally I don't feel confident allowing multiple major versions to be installed — in this case we have to run tests against every major version separately.

Though in this case there were no major updates, only versioning schema was changed.

Also, because pip does not have proper dependency resolver, most likely in case of versions conflict we will have to pin version of importlib_metadata on higher level. One could pin tox there as well and create PR to conflicting package with update of importlib_metadata.

Let's see if we spot any incompatibility, we could always extend range of supported versions.

@gaborbernat

This comment has been minimized.

Copy link
Member

gaborbernat commented Dec 3, 2019

That's why I was suggesting using pipx 👍 which sidesteps all your issues mentioned.

gang65 pushed a commit to gang65/cookiecutter-python that referenced this pull request Dec 10, 2019
Due to tox-dev/tox#1472 in tox,
is is not possible to install tox with with pip and Python 3.8.
After upgrading tox, it is working correctly.

More information about new version of tox, is available at:
https://tox.readthedocs.io/en/latest/changelog.html#v3-14-2-2019-12-02
gang65 pushed a commit to gang65/cookiecutter-python that referenced this pull request Dec 10, 2019
Due to tox-dev/tox#1472 in tox,
is is not possible to install tox with with pip and Python 3.8.
After upgrading tox, it is working correctly.

More information about new version of tox, is available at:
https://tox.readthedocs.io/en/latest/changelog.html#v3-14-2-2019-12-02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.