Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark poetry tests as xfail on windows #1474

Merged

Conversation

@RonnyPfannschmidt
Copy link
Contributor

RonnyPfannschmidt commented Dec 2, 2019

tobgu/pyrsistent#88 triggers extra requirements on building anything on windows,

this also hit poetry, thus its installation fails

the xfail is to make the test-suite green while the situation is being resolved on a more fundamental level

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with "by :user:<your username>"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)
@RonnyPfannschmidt RonnyPfannschmidt changed the title mark poetry tests as xfail on windows [WIP] mark poetry tests as xfail on windows Dec 2, 2019
@RonnyPfannschmidt RonnyPfannschmidt force-pushed the RonnyPfannschmidt:fix-build-xfail-poetry branch from cb35fc6 to 1914ad3 Dec 2, 2019
@RonnyPfannschmidt RonnyPfannschmidt force-pushed the RonnyPfannschmidt:fix-build-xfail-poetry branch from 1914ad3 to 7657314 Dec 2, 2019
@RonnyPfannschmidt RonnyPfannschmidt changed the title [WIP] mark poetry tests as xfail on windows mark poetry tests as xfail on windows Dec 2, 2019
@RonnyPfannschmidt RonnyPfannschmidt force-pushed the RonnyPfannschmidt:fix-build-xfail-poetry branch from 7657314 to 1b3d3fe Dec 2, 2019
Copy link
Member

asottile left a comment

tests/integration/test_package_int.py Outdated Show resolved Hide resolved
RonnyPfannschmidt and others added 2 commits Dec 2, 2019
Co-Authored-By: Anthony Sottile <asottile@umich.edu>
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat merged commit 47e2843 into tox-dev:master Dec 2, 2019
1 check passed
1 check passed
Timeline protection Timeline protection: Good to go
Details
@gaborbernat

This comment has been minimized.

Copy link
Member

gaborbernat commented Dec 2, 2019

thanks

@gaborbernat

This comment has been minimized.

Copy link
Member

gaborbernat commented Dec 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.