Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax importlib_metadata pin #1476

Merged
merged 1 commit into from Dec 3, 2019
Merged

Relax importlib_metadata pin #1476

merged 1 commit into from Dec 3, 2019

Conversation

@chyzzqo2
Copy link
Contributor

chyzzqo2 commented Dec 3, 2019

No description provided.

@gaborbernat

This comment has been minimized.

Copy link
Member

gaborbernat commented Dec 3, 2019

Can demonstrate with an use case why this is needed?

@chyzzqo2

This comment has been minimized.

Copy link
Contributor Author

chyzzqo2 commented Dec 3, 2019

You don't actually require version 1.1. Everything works fine with older versions, in my case using 0.23. There are other libraries that actually break with version > 1. Meaning I either need to pin tox back for my builds or get pip to ignore your pin. So while I can work around this, I still think that it's best to only pin when you actually need to because of breaking APIs or other dependency requirements. Having said that, it's your project so if you disagree feel free to close this and I'll work around the issues it causes.

@gaborbernat

This comment has been minimized.

Copy link
Member

gaborbernat commented Dec 3, 2019

If you're running into compatibility issues with other packages I would recommend using https://github.com/pipxproject/pipx, that installs tox within its own virtual environment avoiding such issues.

GitHub
Install and Run Python Applications in Isolated Environments - pipxproject/pipx
@gaborbernat gaborbernat merged commit 760b034 into tox-dev:master Dec 3, 2019
1 of 2 checks passed
1 of 2 checks passed
Timeline protection Timeline protection: History fragments missing
Details
tox ci #tox ci_20191203.01 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.