Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify legacy setup.py error message further #1478

Merged
merged 1 commit into from Dec 6, 2019

Conversation

@graingert
Copy link
Contributor

graingert commented Dec 3, 2019

a follow up to #1467

python projects should commit to a strong consistency of message regarding packaging. eg we shouldn't tell people to add a setup.py to their already configured pep-517 project, otherwise it could imply that pyproject.toml isn't as well supported and recommended as it truly is

Thanks for contributing a pull request!

If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with "by :user:<your username>"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)
@gaborbernat

This comment has been minimized.

Copy link
Member

gaborbernat commented Dec 4, 2019

thanks

Copy link
Member

gaborbernat left a comment

Can you please fix the tests; and add one for pyproject.toml?

@graingert graingert force-pushed the graingert:patch-1 branch 6 times, most recently from f485d87 to 5188a31 Dec 5, 2019
a follow up to #1467
@graingert graingert force-pushed the graingert:patch-1 branch from 5188a31 to fafe303 Dec 6, 2019
@graingert graingert requested a review from gaborbernat Dec 6, 2019
@graingert

This comment has been minimized.

Copy link
Contributor Author

graingert commented Dec 6, 2019

@gaborbernat new test added, and it should pass CI now

@gaborbernat gaborbernat merged commit 2343c6a into tox-dev:master Dec 6, 2019
2 checks passed
2 checks passed
Timeline protection Timeline protection: Good to go
Details
tox ci #tox ci_20191206.01 succeeded
Details
@graingert graingert deleted the graingert:patch-1 branch Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.