Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid incompatible six #1519

Merged
merged 1 commit into from Feb 13, 2020
Merged

Avoid incompatible six #1519

merged 1 commit into from Feb 13, 2020

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Feb 12, 2020

Avoids problem introduced by newer virtualenv which broke installion
of tox on systems that already had a six version >1.0 installed but
which was older than minimal needed by tox.

Thanks for contributing a pull request!

If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.
Avoids installing tox with a combination of virtualenv-six that is broken, mainly introduced by newer virtualenv which dropped vendored six and which requires six>=1.14.0.

Pip fails to install correct dependency because we list six already as a dependecy. We cannot drop it but we can bump it to assure we avoid ending with incompatible setup.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with "by :user:<your username>"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

@ssbarnea ssbarnea requested a review from gaborbernat Feb 12, 2020
Copy link
Member

@gaborbernat gaborbernat left a comment

I'm ok with this if you can make the CI pass 👍

@ssbarnea
Copy link
Member Author

@ssbarnea ssbarnea commented Feb 12, 2020

@gaborbernat I do see few CI failures which seem fully unrelated to my change. Are they known and not counting for final result? I raised bug at #1520 for them.

I am afraid that due to their less than mainstream nature, these may end-up not being fixed for a long time. Does it makes sense to block other fixes due to them or we should maybe downgrade the support matrix for these? Given enough time we could endup with nothing merging due to a long queue of broken-unrelated bits.

@gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented Feb 12, 2020

They are known but need to be fixed for merges. Can be this or another pr 🤷‍♂️ the reason I did not do this myself is that I don't have time at the moment to fix the ci.

@ssbarnea ssbarnea closed this Feb 12, 2020
@ssbarnea ssbarnea reopened this Feb 12, 2020
@ssbarnea ssbarnea mentioned this pull request Feb 13, 2020
Avoids problem introduced by newer virtualenv which broke installation
of tox on systems that already had a six version >1.0 installed but
which was older than minimal needed by tox.
@gaborbernat gaborbernat merged commit 853deb5 into tox-dev:master Feb 13, 2020
1 of 2 checks passed
bmwiedemann added a commit to bmwiedemann/openSUSE that referenced this issue Mar 26, 2020
https://build.opensuse.org/request/show/786809
by user scarabeus_iv + dimstar_suse
- Disable spinner tests as the monkeypatch changed behaviour in pytest

- version update to 3.14.5
  - Add ``--discover`` (fallback to ``TOX_DISCOVER`` environment variable via path separator) to inject python executables
    to try as first step of a discovery - note the executable still needs to match the environment by :user:`gaborbernat`.
    `#1526 <https://github.com/tox-dev/tox/issues/1526>`_
  - Bump minimal six version needed to avoid using one incompatible with newer
    virtualenv. - by :user:`ssbarnea`
    `#1519 <https://github.com/tox-dev/tox/issues/1519>`_
  - Avoid pypy test failure due to undefined printout var. - by :user:`ssbarnea`
    `#1521 <https://github.com/tox-dev/tox/issues/1521>`_
openstack-mirroring pushed a commit to openstack/sahara that referenced this issue Jan 27, 2021
= six (and tox): the latest versions of tox (which are
compatible with newer virtualenv[1][2]) require a newer six.

[1] https://tox.readthedocs.io/en/latest/changelog.html#v3-14-4-2020-02-13
[2] tox-dev/tox#1519

= alembic: A newer version is required by oslo-db 6.0.0.

= oslo.service: 1.24.0 (and before 1.31.0) capped eventlet to <0.21.0,
but eventlet>0.26.0 is now required.

= cryptography: paramiko 2.7.1 requires cryptography>=2.5.0

= oslo-messaging: bumped to 10.2.0

= greenlet: bumped to 0.4.16 to be compatible with py3.9

= warlock, amqp, pycodestyle: just drop those indirect dependencies
from l-c (and in fact pycodestyle is only a dependency of a linter
for testing).

Change-Id: I26bd73463a5da9ef947f287610b0a33b73062417
openstack-mirroring pushed a commit to openstack/openstack that referenced this issue Jan 27, 2021
* Update sahara from branch 'master'
  to f576d092b7797178e4456e495b6c00a284870bc5
  - Fix lower requirements: bump various packages
    
    = six (and tox): the latest versions of tox (which are
    compatible with newer virtualenv[1][2]) require a newer six.
    
    [1] https://tox.readthedocs.io/en/latest/changelog.html#v3-14-4-2020-02-13
    [2] tox-dev/tox#1519
    
    = alembic: A newer version is required by oslo-db 6.0.0.
    
    = oslo.service: 1.24.0 (and before 1.31.0) capped eventlet to <0.21.0,
    but eventlet>0.26.0 is now required.
    
    = cryptography: paramiko 2.7.1 requires cryptography>=2.5.0
    
    = oslo-messaging: bumped to 10.2.0
    
    = greenlet: bumped to 0.4.16 to be compatible with py3.9
    
    = warlock, amqp, pycodestyle: just drop those indirect dependencies
    from l-c (and in fact pycodestyle is only a dependency of a linter
    for testing).
    
    Change-Id: I26bd73463a5da9ef947f287610b0a33b73062417
ssbarnea added a commit to ssbarnea/tox that referenced this issue Apr 19, 2021
Avoids problem introduced by newer virtualenv which broke installation
of tox on systems that already had a six version >1.0 installed but
which was older than minimal needed by tox.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants