Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude virtualenvs vers w/ regressions 20.0.[0-7] #1537

Conversation

webknjaz
Copy link
Contributor

@webknjaz webknjaz commented Mar 16, 2020

virtualenv 20 series has had a number of regressions. This PR explicitly excludes versions with known issues that are hard to debug.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with "by :user:<your username>"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

@@ -43,7 +43,7 @@ install_requires =
pluggy >= 0.12.0, <1
py >= 1.4.17, <2
six >= 1.14.0, <2 # required when virtualenv>=20
virtualenv >= 16.0.0
virtualenv >= 16.0.0, !=20.0.0, !=20.0.1, !=20.0.2, !=20.0.3, !=20.0.4, !=20.0.5, !=20.0.6, !=20.0.7
Copy link
Member

@gaborbernat gaborbernat Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? Shouldn't install just pick the latest?

Copy link
Member

@asottile asottile Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additionally, though each of these have bugs they "work" for the 95-99% case and it's probably not helpful to exclude it for those already using those versions

Copy link
Contributor Author

@webknjaz webknjaz Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll only install latest if no existing virtualenv is present. So if you do pip install tox and there's virtualenv==20.0.2 there, it'll not upgrade it because it matches the requirement.

Copy link
Contributor Author

@webknjaz webknjaz Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of a better solution atm

Copy link
Member

@gaborbernat gaborbernat Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢 you're right

Copy link
Member

@gaborbernat gaborbernat left a comment

This PR is on hold until we fix the master CI.

@gaborbernat gaborbernat merged commit 9d02cd4 into tox-dev:master Mar 22, 2020
2 of 3 checks passed
@gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented Mar 25, 2020

released via https://pypi.org/project/tox/3.14.6/

ssbarnea pushed a commit to ssbarnea/tox that referenced this issue Apr 19, 2021
* Exclude virtualenvs vers w/ regressions 20.0.[0-7]

* Add a change fragment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants