Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand section names #1545

Merged
merged 5 commits into from Apr 17, 2020
Merged

expand section names #1545

merged 5 commits into from Apr 17, 2020

Conversation

bruchar1
Copy link
Contributor

@bruchar1 bruchar1 commented Mar 26, 2020

This is a proposition to allow generative section names.

In conjecture with factors, it will allow to write more succinct config files, when using factors in the default [testenv] is not sufficient.

Let me know if you like it.

Copy link
Member

@gaborbernat gaborbernat left a comment

I'm not against it, but there's a lot of parts this touches; we need to ensure it does not break anything; e.g. tox -al etc

@bruchar1
Copy link
Contributor Author

@bruchar1 bruchar1 commented Mar 26, 2020

For tox -l, it should not change anything, as this is determined by envlist.
For tox -a, it seems to work as expected, since sections are generated just after reading the ini file, before any parsing.
It shouldn't break non-generative sections, as they are left unchanged.
And all tests pass.

Copy link
Member

@gaborbernat gaborbernat left a comment

Let's add documentation and changelog 👍

@bruchar1
Copy link
Contributor Author

@bruchar1 bruchar1 commented Mar 27, 2020

I added documentation. Feel free to suggest improvements. I'm just not sure what to put for the version number.

@gaborbernat gaborbernat merged commit 1343f3d into tox-dev:master Apr 17, 2020
3 checks passed
@gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented May 2, 2020

Hello, this now has been released via https://pypi.org/project/tox/3.15.0/

heads up

ssbarnea pushed a commit to ssbarnea/tox that referenced this issue Apr 19, 2021
* expand section names

* fix linting

* Added changelog

* trim whitespaces around factor names

* added docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants