Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow both pre- and post- PEP 610 outputs in test_venv_special_chars_issue252 #1594

Merged
merged 1 commit into from Jun 2, 2020

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented Jun 2, 2020

pip 20.1+ supports PEP 610 https://www.python.org/dev/peps/pep-0610/
Hence the output is changed a bit.
This was acknowledged in 553d6f2.

Here we allow to run the tests with pip 19.3.x again
by relaxing the regex to match both the old and the new format.

Thanks for contributing a pull request!

If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation (trivial change)
  • added relevant issue keyword
    in message body (added a commit link)
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with "by :user:<your username>"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (already there)

…issue252

pip 20.1+ supports PEP 610 https://www.python.org/dev/peps/pep-0610/
Hence the output is changed a bit.
This was acknowledged in 553d6f2.

Here we allow to run the tests with pip 19.3.x again
by relaxing the regex to match both the old and the new format.
@asottile asottile merged commit a421aeb into tox-dev:master Jun 2, 2020
25 checks passed
@hroncok hroncok deleted the pip19 branch Jun 2, 2020
@hroncok
Copy link
Contributor Author

hroncok commented Jun 2, 2020

Thanks.

@gaborbernat
Copy link
Member

gaborbernat commented Jun 3, 2020

Do you need a release @hroncok?

@hroncok
Copy link
Contributor Author

hroncok commented Jun 3, 2020

No, I've backported this. Thanks.

ssbarnea pushed a commit to ssbarnea/tox that referenced this issue Apr 19, 2021
…issue252 (tox-dev#1594)

pip 20.1+ supports PEP 610 https://www.python.org/dev/peps/pep-0610/
Hence the output is changed a bit.
This was acknowledged in 553d6f2.

Here we allow to run the tests with pip 19.3.x again
by relaxing the regex to match both the old and the new format.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants