Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add long --verbose/--quiet cli arguments #1612

merged 1 commit into from Jul 12, 2020

Add long --verbose/--quiet cli arguments #1612

merged 1 commit into from Jul 12, 2020


Copy link

@The-Compiler The-Compiler commented Jul 10, 2020

As those are pretty common across different projects I'd say.

Will add tests/changelog (?) if this sounds like a good idea.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with "by :user:<your username>"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

Copy link

@asottile asottile left a comment

probably don't have to bother with tests, though a changelog entry would be good -- thanks!

Copy link
Member Author

The-Compiler commented Jul 12, 2020

Done! 🐱 🙌

Also added tests because modifying the existing ones was trivial, and simplified test_verbose a bit while I was at it.

edit: And added myself to CONTRIBUTORS which I apparently never did!

As those are pretty common across different projects I'd say.
@gaborbernat gaborbernat merged commit 7cd99da into tox-dev:master Jul 12, 2020
25 checks passed
@The-Compiler The-Compiler deleted the patch-1 branch Jul 12, 2020
ssbarnea pushed a commit to ssbarnea/tox that referenced this pull request Apr 19, 2021
As those are pretty common across different projects I'd say.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants