Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update constraint for importlib-metadata #1682

Merged

Conversation

UsamaSadiq
Copy link

@UsamaSadiq UsamaSadiq commented Sep 29, 2020

Thanks for contributing a pull request!

On Python<3.8, importlib-metadata==2.0.0 causes dependency conflicts because of the pinned constraint python<3.8. There is no breaking change in the importlib-metadata version 2.0.0.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with "by :user:<your username>"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

@UsamaSadiq UsamaSadiq force-pushed the relax-importlib-metadata-constraint branch 3 times, most recently from 8940e84 to 05493c2 Compare Sep 29, 2020
docs/changelog.rst Outdated Show resolved Hide resolved
@UsamaSadiq UsamaSadiq force-pushed the relax-importlib-metadata-constraint branch from 05493c2 to 9d68dba Compare Sep 29, 2020
@UsamaSadiq UsamaSadiq requested a review from gaborbernat Sep 29, 2020
@gaborbernat gaborbernat marked this pull request as ready for review Sep 29, 2020
@gaborbernat gaborbernat merged commit 471b39f into tox-dev:master Sep 29, 2020
1 check passed
@UsamaSadiq
Copy link
Author

UsamaSadiq commented Sep 29, 2020

Hi @gaborbernat, thanks for merging the fix. Could you tell me when the next release is planned for tox? Should I make a PR for releasing a new version as well to get this fix updated on PyPI, if the main release is late in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants