Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve documentation for install_command #2111

Merged
merged 2 commits into from Jul 21, 2021
Merged

improve documentation for install_command #2111

merged 2 commits into from Jul 21, 2021

Conversation

jugmac00
Copy link
Member

@jugmac00 jugmac00 commented Jul 20, 2021

This fixes #2081.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with "by :user:<your username>"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

Copy link
Member

@gaborbernat gaborbernat left a comment

Slight change.

docs/config.rst Outdated Show resolved Hide resolved
The documentation now mentions that you can provide arbitrary commands
to ``install_command``.

This fixes #2081.

apply pr feedback
Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
@gaborbernat gaborbernat merged commit 20d0646 into master Jul 21, 2021
2 of 3 checks passed
@gaborbernat gaborbernat deleted the issue_2081 branch Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to run run tox and fails with error "could not install deps"
2 participants