Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alow backend build system to omit get_requires_for_build_sdist hook #2131

Merged
merged 5 commits into from Jul 31, 2021

Conversation

oczkoisse
Copy link
Contributor

@oczkoisse oczkoisse commented Jul 31, 2021

Fixes #2130. Briefly, PEP 517 permits some optional hooks for a backend build system. In particular, if get_requires_for_build_sdist hook is not implemented by the backend, a default implementation that returns an empty list must be assumed. This fix should allow enscons (a build system based on SCons) to work with tox when isolated build option is enabled.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with "by :user:<your username>"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

@oczkoisse oczkoisse changed the title Fix enscons isolated build Fix #2130: allow backend build system to omit get_requires_for_build_sdist hook Jul 31, 2021
@oczkoisse oczkoisse changed the title Fix #2130: allow backend build system to omit get_requires_for_build_sdist hook Alow backend build system to omit get_requires_for_build_sdist hook Jul 31, 2021
Copy link
Member

@jugmac00 jugmac00 left a comment

Thanks for your contribution!

Could you please add a changelog entry? (docs/changelog)

We use towncrier for changelogs.

@gaborbernat gaborbernat merged commit db5861c into tox-dev:master Jul 31, 2021
30 checks passed
@gaborbernat
Copy link
Member

gaborbernat commented Jul 31, 2021

Released via https://pypi.org/project/tox/3.24.1/

@oczkoisse oczkoisse deleted the fix-enscons-isolated-build branch Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Isolated build with 'enscons' as backend build system fails
3 participants