Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASCII output for --parallel report lines #2164

Merged
merged 2 commits into from Aug 21, 2021

Conversation

brettcs
Copy link
Contributor

@brettcs brettcs commented Aug 20, 2021

This is a branch to fix #1421 by providing ASCII equivalent messages for the OK/FAIL/SKIP lines that summarize the result for each environment.

I chose strings reminiscent of the sysvinit boot service banners on older Linux distros. If you'd rather use something else, of course it's no problem for anyone else to switch out those strings. The code should continue to work no problem.

Hope this helps!

This class provides a single interface for spinner strings where we
ideally want to report Unicode but want to fall back to ASCII when the
terminal doesn't support it.
@brettcs
Copy link
Contributor Author

brettcs commented Aug 20, 2021

Sorry about the test failures on older Pythons. I can tackle those but it might be a few days.

@brettcs brettcs force-pushed the parallel-ascii-report branch from 1da9a6e to 833e4b1 Compare Aug 21, 2021
@gaborbernat gaborbernat merged commit 8f5ca11 into tox-dev:master Aug 21, 2021
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--parallel: Unicode output for status in ASCII mode
2 participants