Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Fix the last version+date underline in changelog #2165

Merged
merged 1 commit into from Aug 20, 2021

Conversation

webknjaz
Copy link
Contributor

@webknjaz webknjaz commented Aug 20, 2021

The current changelog has invalid syntax with a missing title underline rendering ugly plain text merge of two titles ("version+date" title + "bugfix" title). This patch addresses the immediate problem but I haven't checked what caused it (whether it's automation that is broken or a simple human error).

tox-broken-changelog-title

I'm not adding a change note because it seems unnecessary in this case.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with "by :user:<your username>"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

Copy link
Member

@asottile asottile left a comment

I think towncrier had some sort of regression 馃し

@asottile asottile merged commit 29a1ca9 into tox-dev:master Aug 20, 2021
4 of 30 checks passed
@webknjaz
Copy link
Contributor Author

webknjaz commented Aug 20, 2021

I think towncrier had some sort of regression

Most likely, the latest version at least, has a regression in adding the title that was exposed as a difference between normal and --draft runs in sphinxcontrib-towncrier: sphinx-contrib/sphinxcontrib-towncrier#48 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants