Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摑 Document when {tty} was added #2166

Merged
merged 1 commit into from Aug 20, 2021

Conversation

webknjaz
Copy link
Contributor

@webknjaz webknjaz commented Aug 20, 2021

I used the {tty} substitution in a tox.ini of one project and the minimum version set was ancient (~1.5) so I wanted to find out when it was introduced and both places where I'd expect this info weren't helpful.

I tracked it down to v3.4.0 via git blame, of course. But I think it'd be useful to actually have it in the Sphinx docs. So here you go. No change note because it's unnecessary here.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with "by :user:<your username>"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

Copy link
Member

@asottile asottile left a comment

@asottile asottile merged commit 63c98c2 into tox-dev:master Aug 20, 2021
30 of 31 checks passed
webknjaz added a commit to webknjaz/ansible-navigator that referenced this pull request Aug 21, 2021
webknjaz added a commit to webknjaz/ansible-navigator that referenced this pull request Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants