Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only respect ALL environments when not in parallel #2207

Merged
merged 1 commit into from Sep 13, 2021
Merged

Only respect ALL environments when not in parallel #2207

merged 1 commit into from Sep 13, 2021

Conversation

guahki
Copy link
Contributor

@guahki guahki commented Sep 9, 2021

fixes #2167

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation, breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with -- by :user:`<your username>`.
    • please, use full sentences with correct case and punctuation, for example:
      Fixed an issue with non-ascii contents in doctest text files -- by :user:`superuser`.
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

@guahki
Copy link
Contributor Author

guahki commented Sep 9, 2021

As

  1. this is my first contribution to this project and
  2. I'm not sure about the correct way to fix this

this is kind of a draft/request PR. I will happily create appropriate changelog when you tell me, this is a sensible way of fixing the problem.

Thanks for the awesome tox tool!

@guahki guahki marked this pull request as draft Sep 9, 2021
src/tox/config/__init__.py Outdated Show resolved Hide resolved
@guahki guahki marked this pull request as ready for review Sep 9, 2021
@gaborbernat gaborbernat marked this pull request as draft Sep 9, 2021
Copy link
Member

@gaborbernat gaborbernat left a comment

Can you please add changelog and test for this?

@guahki
Copy link
Contributor Author

guahki commented Sep 9, 2021

I added the changelog.

Unfortunately I do not have the time to write a test right now (as I would have to dig deep into this to understand how to even test this behavior of the subprocess invocation). I would be happy, if anybody can assist with this.

@guahki guahki requested a review from gaborbernat Sep 9, 2021
@gaborbernat gaborbernat added the help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted. label Sep 10, 2021
@gaborbernat gaborbernat marked this pull request as ready for review Sep 11, 2021
@gaborbernat gaborbernat marked this pull request as draft Sep 11, 2021
Copy link
Member

@gaborbernat gaborbernat left a comment

This still needs a test, check around the test suite to find instances of this.

@guahki
Copy link
Contributor Author

guahki commented Sep 13, 2021

I had a look into it and it wasn't that hard indeed.
Thanks for your patience!

@guahki guahki marked this pull request as ready for review Sep 13, 2021
@guahki guahki requested a review from gaborbernat Sep 13, 2021
@gaborbernat gaborbernat merged commit 3c1c29a into tox-dev:master Sep 13, 2021
31 checks passed
@guahki guahki deleted the issue-2167-fix-parallel-ALL branch Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants