New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix oversight in fixing #595: inherit new exception from Error #635

Merged
merged 1 commit into from Sep 15, 2017

Conversation

Projects
3 participants
@obestwalter
Member

obestwalter commented Sep 15, 2017

No description provided.

@codecov

This comment has been minimized.

codecov bot commented Sep 15, 2017

Codecov Report

Merging #635 into master will increase coverage by 0.59%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #635      +/-   ##
==========================================
+ Coverage   93.35%   93.95%   +0.59%     
==========================================
  Files          11       11              
  Lines        2364     2364              
==========================================
+ Hits         2207     2221      +14     
+ Misses        157      143      -14
Impacted Files Coverage Δ
tox/__init__.py 93.33% <100%> (ø) ⬆️
tox/_verlib.py 83.15% <0%> (+14.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 938f0ef...a4fa896. Read the comment docs.

@obestwalter obestwalter merged commit 0091126 into tox-dev:master Sep 15, 2017

4 checks passed

codecov/patch 100% of diff hit (target 93.35%)
Details
codecov/project 93.95% (+0.59%) compared to 938f0ef
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@@ -16,7 +16,7 @@ class Error(Exception):
def __str__(self):
return "%s: %s" % (self.__class__.__name__, self.args[0])
class MissingSubstitution(Exception):

This comment has been minimized.

@RonnyPfannschmidt

RonnyPfannschmidt Sep 15, 2017

Contributor

isnt it a LookupError?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment