Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix oversight in fixing #595: inherit new exception from Error #635

Merged
merged 1 commit into from Sep 15, 2017
Merged

fix oversight in fixing #595: inherit new exception from Error #635

merged 1 commit into from Sep 15, 2017

Conversation

@obestwalter
Copy link
Member

@obestwalter obestwalter commented Sep 15, 2017

No description provided.

@codecov
Copy link

@codecov codecov bot commented Sep 15, 2017

Codecov Report

Merging #635 into master will increase coverage by 0.59%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #635      +/-   ##
==========================================
+ Coverage   93.35%   93.95%   +0.59%     
==========================================
  Files          11       11              
  Lines        2364     2364              
==========================================
+ Hits         2207     2221      +14     
+ Misses        157      143      -14
Impacted Files Coverage Δ
tox/__init__.py 93.33% <100%> (ø) ⬆️
tox/_verlib.py 83.15% <0%> (+14.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 938f0ef...a4fa896. Read the comment docs.

@obestwalter obestwalter merged commit 0091126 into tox-dev:master Sep 15, 2017
4 checks passed
@@ -16,7 +16,7 @@ class Error(Exception):
def __str__(self):
return "%s: %s" % (self.__class__.__name__, self.args[0])

class MissingSubstitution(Exception):
Copy link
Contributor

@RonnyPfannschmidt RonnyPfannschmidt Sep 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isnt it a LookupError?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants