New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid escape sequence fixes #638

Merged
merged 2 commits into from Sep 16, 2017

Conversation

Projects
5 participants
@scop
Contributor

scop commented Sep 15, 2017

No description provided.

@codecov

This comment has been minimized.

codecov bot commented Sep 16, 2017

Codecov Report

Merging #638 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #638   +/-   ##
=======================================
  Coverage   93.95%   93.95%           
=======================================
  Files          11       11           
  Lines        2364     2364           
=======================================
  Hits         2221     2221           
  Misses        143      143
Impacted Files Coverage Δ
tox/interpreters.py 82.03% <ø> (ø) ⬆️
tox/config.py 97.57% <100%> (ø) ⬆️
tox/session.py 94.34% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0091126...e92ad57. Read the comment docs.

@The-Compiler

This comment has been minimized.

Contributor

The-Compiler commented Sep 16, 2017

I'm wondering why we didn't notice earlier? Maybe it'd be a good idea to turn on -Werror for the testsuite?

@obestwalter

This comment has been minimized.

Member

obestwalter commented Sep 16, 2017

woah - if I run pytest -Werror basically everything fails for using old pytest constructs ...

@obestwalter obestwalter merged commit 6b1b65b into tox-dev:master Sep 16, 2017

4 checks passed

codecov/patch 100% of diff hit (target 93.95%)
Details
codecov/project 93.95% (+0%) compared to 0091126
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@scop scop deleted the scop:escseq branch Sep 16, 2017

@obestwalter obestwalter added this to pull requests in [released] 2.9.x Sep 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment